Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CLI integration test #3898

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Update CLI integration test #3898

merged 2 commits into from
Oct 11, 2024

Conversation

bitoku
Copy link
Collaborator

@bitoku bitoku commented Oct 10, 2024

Which issue this PR addresses:

Fixes https://issues.redhat.com/browse/ARO-8293

What this PR does / why we need it:

This PR implements a scenario-based integration test for all subcommands.
This will increase the test coverage in ARO-RP repo, and will reduce the test execution time in upstream because it doesn't create a cluster for each subcommand.

I'm going to open a PR in upstream after this PR is merged.

Test plan for issue:

Run azdev test.
https://github.com/Azure/ARO-RP/blob/master/docs/az-aro-python-development.md#tests

Is there any documentation that needs to be updated for this PR?

na

How do you know this will function as expected in production?

not production feature.

@bitoku
Copy link
Collaborator Author

bitoku commented Oct 10, 2024

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@bitoku bitoku changed the title Change CLI integration test Update CLI integration test Oct 10, 2024
tsatam
tsatam previously approved these changes Oct 10, 2024
Copy link
Collaborator

@tsatam tsatam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, there's a couple non-blocking questions/followups that can either be handled here or in follow-up efforts.

@bitoku
Copy link
Collaborator Author

bitoku commented Oct 11, 2024

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@tsatam tsatam merged commit 53673d4 into master Oct 11, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants